Skip broken tests on Windows ARM64 #47020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
|
Thanks, @StefanStojanovic. Looks good to me. |
StefanStojanovic
changed the title
StefanStojanovic
changed the title
StefanStojanovic
force-pushed
the
mefi-arm64-flaky-tests
branch
from
a12ebf7
to
1da7569
Compare
|
@sxa @richardlau hey, I'm not sure who to ping for this. I saw you were active on ARM64 and some test PRs in the past so I picked you. Anyway, I wanted to see if there is something I can do to help move this forward. I apologize for pinging you and if there is someone else who I should ping for this please let me know. Thanks in advance. |
richardlau
reviewed
Mar 14, 2023
StefanStojanovic
force-pushed
the
mefi-arm64-flaky-tests
branch
from
1da7569
to
5e8dfbc
Compare
richardlau
approved these changes
Mar 20, 2023
targos
approved these changes
Mar 20, 2023
|
@richardlau @targos can one of you trigger CI and/or merge this, please? |
github-actions
bot
removed
the
request-ci
19 tasks
targos
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in f086555 |
33 tasks
StefanStojanovic
added a commit
to JaneaSystems/node
that referenced
this pull request
Mar 23, 2023
StefanStojanovic
added a commit
to JaneaSystems/node
that referenced
this pull request
Mar 23, 2023
Refs: nodejs#45943 Refs: nodejs#47020 Refs: nodejs/build#3046 Refs: nodejs/build#3246 Refs: nodejs/build#3250 Refs: nodejs/build#3211
nodejs-github-bot
pushed a commit
that referenced
this pull request
Mar 27, 2023
Refs: #47020 Refs: nodejs/build#3046 PR-URL: #47235 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Mar 28, 2023
PR-URL: #47020 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Mar 28, 2023
Refs: #47020 Refs: nodejs/build#3046 PR-URL: #47235 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
This was referenced Apr 3, 2023
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 7, 2023
PR-URL: #47020 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 7, 2023
Refs: #47020 Refs: nodejs/build#3046 PR-URL: #47235 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #47020 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
Refs: #47020 Refs: nodejs/build#3046 PR-URL: #47235 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR marks 2 tests for skipping on Windows on ARM. The changes introduced here aim to enable passing JS test suites in the CI. There is another PR that focuses on native test suites. Together their goal is to enable Windows ARM64 tests in CI
cc @nodejs/platform-windows-arm